Fix separator and spacer blocks after api v2 refactoring. #26157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
requested review from
ajitbohra,
Soean and
talldan
as code owners
ellatrix
reviewed
Oct 15, 2020
|
Size Change: +8 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
fix/separator-mobile
branch
from
3ec83bb
to
39872e0
Compare
ellatrix
approved these changes
Oct 15, 2020
ellatrix
reviewed
Oct 15, 2020
| @@ -48,7 +49,7 @@ const SpacerEdit = ( { | |||
|
|
|||
| return ( | |||
| <> | |||
| <div { ...useBlockProps() }> | |||
There was a problem hiding this comment.
Ideally we should avoid this and make the wrapper itself resizable. I'll look into that.
There was a problem hiding this comment.
yes, I tried it and I believe there's something with the "ref" not being forwarded properly to the third-party dependency.
Tug
reviewed
Oct 15, 2020
| @@ -0,0 +1,3 @@ | |||
| # View | |||
|
|
|||
| A drop-in replacement for the div element that works across devices. | |||
geriux
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also introduces the "View" primitive between mobile and web. The main question for me here is what props this primitive should accept. Implicitly here, it already accepts a bunch of web props (className, style, role, ref) generated by useBlockProps but I guess the native version of useBlockProps could generate different ones (or we find a device-agnostic way to define these styles and properties).